Copy http headers from main controller to sub controllers#3213
Open
chenBright wants to merge 1 commit intoapache:masterfrom
Open
Copy http headers from main controller to sub controllers#3213chenBright wants to merge 1 commit intoapache:masterfrom
chenBright wants to merge 1 commit intoapache:masterfrom
Conversation
wwbmmm
reviewed
Feb 4, 2026
| // Forward request attachment to the subcall | ||
| sub_cntl->request_attachment().append(_main_cntl->request_attachment()); | ||
| sub_cntl->http_request() = _main_cntl->http_request(); | ||
| if (PROTOCOL_HTTP == _main_cntl->request_protocol()) { |
Contributor
There was a problem hiding this comment.
maybe this can also apply to PROTOCOL_H2
| ParallelChannelDone::SubDone* sd = d->sub_done(j++); | ||
| // Forward the attachment to each sub call | ||
| sd->cntl.request_attachment().append(cntl->request_attachment()); | ||
| if (PROTOCOL_HTTP == cntl->request_protocol()) { |
Contributor
There was a problem hiding this comment.
The current ParallelChannel is not friendly to http protocol if user want to set different http request params for different sub call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: resolve #3211
Problem Summary:
What is changed and the side effects?
Changed:
Side effects:
Performance effects:
Breaking backward compatibility:
Check List: